Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make TokenManager#token_ttl callable (evaluated at call time) #15124

Merged
merged 4 commits into from
May 19, 2017
Merged

Make TokenManager#token_ttl callable (evaluated at call time) #15124

merged 4 commits into from
May 19, 2017

Commits on May 17, 2017

  1. Add a #token_ttl method so we can sense ttl values

    @imtayadeway
    imtayadeway committed May 17, 2017
    Configuration menu
    Copy the full SHA
    e3a880a View commit details
    Browse the repository at this point in the history

  2. s/token_ttl/ttl/ so as not to confused with #token_ttl

    @imtayadeway
    imtayadeway committed May 17, 2017
    Configuration menu
    Copy the full SHA
    e47f599 View commit details
    Browse the repository at this point in the history

  3. Use the wrapped #token_ttl instead of going through @options

    @imtayadeway
    imtayadeway committed May 17, 2017
    Configuration menu
    Copy the full SHA
    49cf6aa View commit details
    Browse the repository at this point in the history

  4. Make token_ttl callable (evaluated at call time) 

    If we pass in a value that can change (i.e. settings), it's evaluated
once at construction time and will never change. Thus, if a user
changes the session time out setting, a restart of the server is
required.

By making this value callable we can delay evaluation until call time,
which honors updated settings values.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1451848
    @imtayadeway
    imtayadeway committed May 17, 2017
    Configuration menu
    Copy the full SHA
    9fa3858 View commit details
    Browse the repository at this point in the history