Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not offer report columns that are useless #15261

Merged
merged 1 commit into from
Jun 6, 2017
Merged

Do not offer report columns that are useless #15261

merged 1 commit into from
Jun 6, 2017

Conversation

isimluk
Copy link
Member

@isimluk isimluk commented May 31, 2017

@isimluk
Copy link
Member Author

isimluk commented May 31, 2017

I think the spec may fail until #15260 is merged.

@miq-bot
Copy link
Member

miq-bot commented May 31, 2017

Checked commit isimluk@22570ac with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

gtanzillo
gtanzillo approved these changes Jun 6, 2017
View reviewed changes
Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gtanzillo gtanzillo added this to the Sprint 62 Ending Jun 5, 2017 milestone Jun 6, 2017
@gtanzillo gtanzillo merged commit d07a5ef into ManageIQ:master Jun 6, 2017
@simaishi
Copy link
Contributor

simaishi commented Jun 6, 2017

@isimluk @gtanzillo this can be fine/yes and euwe/yes?

simaishi pushed a commit that referenced this pull request Jun 7, 2017
@gtanzillo @simaishi
Merge pull request #15261 from isimluk/do-not-offer-useless-metrics
f4fc220 
Do not offer report columns that are useless
(cherry picked from commit d07a5ef)

https://bugzilla.redhat.com/show_bug.cgi?id=1459563
@simaishi
Copy link
Contributor

simaishi commented Jun 7, 2017

Euwe backport details:

git log -1
commit f4fc22026014b8692513efba4f9892b6d1380505
Author: Gregg Tanzillo <gtanzill@redhat.com>
Date:   Mon Jun 5 23:24:25 2017 -0400

    Merge pull request #15261 from isimluk/do-not-offer-useless-metrics
    
    Do not offer report columns that are useless
    (cherry picked from commit d07a5ef227d0d8b15ea343a94c914d6396485970)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1459563

@simaishi
Copy link
Contributor

simaishi commented Jun 7, 2017 •
edited
Loading

@isimluk Travis is red on Euwe (https://travis-ci.org/ManageIQ/manageiq/jobs/240363371). Looks like spec change done in #15260 is needed here? Can you create an Euwe PR to fix the failure?

@isimluk
Copy link
Member Author

isimluk commented Jun 9, 2017

Sorry about that: here is the medicine #15337

simaishi pushed a commit that referenced this pull request Jun 12, 2017
@gtanzillo @simaishi
Merge pull request #15261 from isimluk/do-not-offer-useless-metrics
1820f3c 
Do not offer report columns that are useless
(cherry picked from commit d07a5ef)

https://bugzilla.redhat.com/show_bug.cgi?id=1459562
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit 1820f3c43f862e8164d988167cd1db06cacbe246
Author: Gregg Tanzillo <gtanzill@redhat.com>
Date:   Mon Jun 5 23:24:25 2017 -0400

    Merge pull request #15261 from isimluk/do-not-offer-useless-metrics
    
    Do not offer report columns that are useless
    (cherry picked from commit d07a5ef227d0d8b15ea343a94c914d6396485970)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1459562

@lpichler lpichler mentioned this pull request Jun 23, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtanzillo gtanzillo gtanzillo approved these changes

Assignees

@gtanzillo gtanzillo

Labels
bug core/chargeback euwe/backported fine/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@isimluk @miq-bot @simaishi @gtanzillo