[EUWE] Do not calculate useless group metrics #15337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://bugzilla.redhat.com/show_bug.cgi?id=1455690 https://bugzilla.redhat.com/show_bug.cgi?id=1454456 - cpu is useless as it counts usagemhz and vm_numvcpus together - cpu_cores is useless as it only reports cpu_cores - memory is useless as counts used and available together - net_io is useless as it only reports net_ui_rate_avg - disk_io is useless as it only reports disk_usage_rate_avg - storage is useless as it counts used and allocated together - fixed is useless as it counts all the fixed metrics together (that equals to 4 for each day, not useful) (cherry picked from commit afb10c1) Conflicts: app/models/chargeable_field.rb spec/models/chargeback_vm_spec.rb
isimluk
force-pushed
the
euwe-backport-15260
branch
from
8e88f14
to
a5c8a79
Compare
|
Checked commit isimluk@a5c8a79 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
lpichler
approved these changes
Jun 9, 2017
gtanzillo
approved these changes
Jun 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of #15260. To make the tests green.
https://bugzilla.redhat.com/show_bug.cgi?id=1455690
https://bugzilla.redhat.com/show_bug.cgi?id=1454456
(that equals to 4 for each day, not useful)
(cherry picked from commit afb10c1)
Conflicts:
app/models/chargeable_field.rb
spec/models/chargeback_vm_spec.rb