Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle setup playbook failure better #15313

Merged
merged 2 commits into from
Jun 6, 2017
Merged

Handle setup playbook failure better #15313

merged 2 commits into from
Jun 6, 2017

Commits on Jun 6, 2017

  1. Handle additional case for /etc/tower/SECRET_KEY 

    Previously if we had a value in the database, but the file
didn't exist on the filesystem .configured? would raise an error
when it should really just return false and we will write out
the value from the database to the filesystem.

https://bugzilla.redhat.com/show_bug.cgi?id=1439783
https://bugzilla.redhat.com/show_bug.cgi?id=1458886
    @carbonin
    carbonin committed Jun 6, 2017
    Configuration menu
    Copy the full SHA
    42eb2f8 View commit details
    Browse the repository at this point in the history

  2. Remove the secret key from the database when the setup fails 

    This will force `.configured?` to false the next time `.start` is run
allowing us to retry the configuration.

Before this change, users would have to blank the SECRET_KEY file
on the filesystem to force a retry.

https://bugzilla.redhat.com/show_bug.cgi?id=1439783
https://bugzilla.redhat.com/show_bug.cgi?id=1458886
    @carbonin
    carbonin committed Jun 6, 2017
    Configuration menu
    Copy the full SHA
    f80e6dd View commit details
    Browse the repository at this point in the history