Fail explicitly for MAS validation failure #15473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moolitayer
changed the title
9 tasks
|
@gmcculloug can you take a look? |
|
Looks good, just missing tests. |
|
@moolitayer is there a GitHub Issue or Bugzilla Case that this PR is addressing? |
|
No, just an issue I encountered during development. |
|
@gmcculloug done, please take a look |
|
Checked commit moolitayer@01626ae with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During
MiqAlert.evaluatewhen creating a new MiqAlertStatus, validation can fail[1].In those cases we should fail the operation. Otherwise we can have a MiqAlert evaluated as true and silently not create a MAS.
[1] e.g
mas.severity= 'unknown'