Return VMs and Templates for EMS prev_relats #15671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When retrieving vmdb_relats_ems we weren't including templates in the list of children for folders. This isn't an issue for clusters, hosts, and resource_pools because templates don't belong to any of these but they do belong to folders. If a VM was marked as a template and moved into a new folder it was not being included in the prev_relats which meant that its previous resource_pool and folder relat were not being deleted, but we were adding a new folder relationship. This caused the "multiple parents found" exception seen occasionally on the UI while provisioning. https://bugzilla.redhat.com/show_bug.cgi?id=1475405
agrare
force-pushed
the
bz_1475405_multiple_parents_found
branch
from
c0bb826
to
b1ed3c8
Compare
|
Checked commit agrare@b1ed3c8 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
blomquisg
approved these changes
Jul 27, 2017
|
Great find @agrare !! |
|
After applying this patch just running a full refresh will clean up any existing stale relationships without needing to run the |
simaishi
pushed a commit
that referenced
this pull request
Aug 2, 2017
Return VMs and Templates for EMS prev_relats (cherry picked from commit 3c599e9) https://bugzilla.redhat.com/show_bug.cgi?id=1477722
|
Euwe backport details: |
|
Should also backport #15692 to fix a sporadic test failure |
simaishi
pushed a commit
that referenced
this pull request
Aug 9, 2017
Return VMs and Templates for EMS prev_relats (cherry picked from commit 3c599e9) https://bugzilla.redhat.com/show_bug.cgi?id=1479805
|
Fine backport details: |
|
+1 |
d-m-u
pushed a commit
to d-m-u/manageiq
that referenced
this pull request
Jun 6, 2018
…ents_found Return VMs and Templates for EMS prev_relats (cherry picked from commit 3c599e9) https://bugzilla.redhat.com/show_bug.cgi?id=1479805
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When retrieving vmdb_relats_ems we weren't including templates in the
list of children for folders. This isn't an issue for clusters, hosts,
and resource_pools because templates don't belong to any of these but
they do belong to folders.
If a VM was marked as a template and moved into a new folder it was not
being included in the prev_relats which meant that its previous
resource_pool and folder relat were not being deleted, but we were
adding a new folder relationship. This caused the "multiple parents
found" exception seen occasionally on the UI while provisioning.
https://bugzilla.redhat.com/show_bug.cgi?id=1475405
Steps to reproduce:
With evmserver stopped (needed to ensure a full refresh is run)
In rails console:
In VMware Client:
2. Move a template into a different folder
In rails console:
3. Run another full refresh (Note: with a running system this can happen for a few reasons, in the case of this ticket the new folder event got merged causing the full refresh)
4. Print the parent blue folder (
VmOrTemplate.find_by(:name => "foo").parent_blue_folder)Before this patch this should result in the
multiple parent foundexception.