Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matching on array order is failing sporadically #15692

Merged

Conversation

agrare
Copy link
Member

@agrare agrare commented Jul 31, 2017

Since the test is comparing the full hashes it is also checking the array order. Change test so there is not more than 1 child in a folder.

Introduced by the tests in #15671

@miq-bot
Copy link
Member

miq-bot commented Jul 31, 2017

Checked commit agrare@87f63c4 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 6 offenses detected

spec/models/ems_refresh/metadata_relats_spec.rb

@blomquisg blomquisg merged commit 81debfd into ManageIQ:master Jul 31, 2017
@blomquisg blomquisg added this to the Sprint 66 Ending Aug 7, 2017 milestone Jul 31, 2017
@agrare agrare deleted the fix_sporadic_metadata_relats_failure branch July 31, 2017 15:51
simaishi pushed a commit that referenced this pull request Aug 2, 2017
…ilure

Matching on array order is failing sporadically
(cherry picked from commit 81debfd)

https://bugzilla.redhat.com/show_bug.cgi?id=1477722
@simaishi
Copy link
Contributor

simaishi commented Aug 2, 2017

Euwe backport details:

$ git log -1
commit 2d5a70be5685b66b61cf1564c5f22ac917e2bd4c
Author: Greg Blomquist <blomquisg@gmail.com>
Date:   Mon Jul 31 11:34:27 2017 -0400

    Merge pull request #15692 from agrare/fix_sporadic_metadata_relats_failure
    
    Matching on array order is failing sporadically
    (cherry picked from commit 81debfd3f5ed525d960643da702f1f5e57020a57)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1477722

simaishi pushed a commit that referenced this pull request Aug 9, 2017
…ilure

Matching on array order is failing sporadically
(cherry picked from commit 81debfd)

https://bugzilla.redhat.com/show_bug.cgi?id=1479805
@simaishi
Copy link
Contributor

simaishi commented Aug 9, 2017

Fine backport details:

$ git log -1
commit a3860b7fed9416486dd6a0588b8126eed56d9575
Author: Greg Blomquist <blomquisg@gmail.com>
Date:   Mon Jul 31 11:34:27 2017 -0400

    Merge pull request #15692 from agrare/fix_sporadic_metadata_relats_failure
    
    Matching on array order is failing sporadically
    (cherry picked from commit 81debfd3f5ed525d960643da702f1f5e57020a57)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1479805

d-m-u pushed a commit to d-m-u/manageiq that referenced this pull request Jun 6, 2018
…elats_failure

Matching on array order is failing sporadically
(cherry picked from commit 81debfd)

https://bugzilla.redhat.com/show_bug.cgi?id=1479805
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants