Set user's group to the requester group. #15696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmcculloug
changed the title
gmcculloug
changed the title
gmcculloug
reviewed
Aug 2, 2017
spec/models/miq_request_spec.rb
Outdated
| it "stays with the requester group" do | ||
| expect(user.current_group).to eq(group1) | ||
| expect(request.get_user.current_group).to eq(group2) | ||
| end |
There was a problem hiding this comment.
@lfu Can you also add a tests for the case where the user does not share a group with the options[:requester_group] value. In that case the user remains in their current group.
User's current group might have changed before the provision finishes. So the user's current group from DB may be different from the user's group when the request is made. Need to set the user's group back to requester group the user is in when the provision is submitted. Therefore the provisioned instances may belong to the right user/group/tenant. https://bugzilla.redhat.com/show_bug.cgi?id=1467364
lfu
force-pushed
the
service_user_in_groups_1467364
branch
from
da8fa87
to
97b099d
Compare
|
Checked commit lfu@97b099d with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
simaishi
pushed a commit
that referenced
this pull request
Aug 9, 2017
Set user's group to the requester group. (cherry picked from commit 1d2c55f) https://bugzilla.redhat.com/show_bug.cgi?id=1480007
|
Fine backport details: |
simaishi
pushed a commit
that referenced
this pull request
Aug 15, 2017
Set user's group to the requester group. (cherry picked from commit 1d2c55f) https://bugzilla.redhat.com/show_bug.cgi?id=1481859
|
Euwe backport details: |
d-m-u
pushed a commit
to d-m-u/manageiq
that referenced
this pull request
Jun 6, 2018
…7364 Set user's group to the requester group. (cherry picked from commit 1d2c55f) https://bugzilla.redhat.com/show_bug.cgi?id=1480007
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User's current group might have changed before the provision finishes.
So the user's current group from DB may be different from the user's group when the request is made.
Need to set the user's group back to requester group the user is in when the provision is submitted.
Therefore the provisioned instances may belong to the right user/group/tenant.
Includes ManageIQ/manageiq-content#156.Includes ManageIQ/manageiq-automation_engine#61.
https://bugzilla.redhat.com/show_bug.cgi?id=1467364
@miq-bot assign @gmcculloug
@miq-bot add_label services, euwe/yes, fine/yes