[FINE] Backport of: fixed cases causing waiting on timeout in vm_import #15784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a backport of ManageIQ/manageiq-providers-ovirt/pull/73/ It tries to be a minimal backport needed but still includes all the relevant tests. 2 problems fixed: - allow to import only using 4.1.5+ provider. The reason is that the required fix (https://bugzilla.redhat.com/1477375) is present in 4.1.5+ and without this fix manageiq will wait until timeout reached. - check if submit to the provider succeeded. The reason is that if the result is not checked, this state will always succeed and the import will again wait until timeout.
jelkosz
force-pushed
the
vm_import_fix_issues_causing_timeouts
branch
from
86836c8
to
2881ec2
Compare
|
Checked commit jelkosz@2881ec2 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
the test failure is unrelated - it is fixed by #15782 |
masayag
approved these changes
Aug 10, 2017
chessbyte
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of ManageIQ/manageiq-providers-ovirt/pull/73/ solving the merge conflicts.
Please note this has to be backported together with ManageIQ/manageiq-content/pull/168 to avoid failing tests on the manageiq-content repo.
It tries to be a minimal backport needed but still includes all the relevant
tests.
2 problems fixed:
The reason is that the required fix (https://bugzilla.redhat.com/1477375) is
present in 4.1.5+ and without this fix manageiq will wait until timeout
reached.
The reason is that if the result is not checked, this state will always
succeed and the import will again wait until timeout.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1473169