Log playbook stdout according to options #16333
Conversation
|
@miq-bot add_label enhancement |
| @@ -97,6 +99,11 @@ def ansible_job | |||
| ManageIQ::Providers::EmbeddedAnsible::AutomationManager::Job.find(options[:tower_job_id]) | |||
| end | |||
|
|
|||
| def set_status(message, status = "ok") | |||
There was a problem hiding this comment.
@bzwei - Where does this come into play for this PR
There was a problem hiding this comment.
Nevermind - Missed the call to super
| @@ -173,4 +180,13 @@ def delete_job_template | |||
| _log.log_backtrace(err) | |||
| false | |||
| end | |||
|
|
|||
| def log_stdout(succeeded) | |||
There was a problem hiding this comment.
It's hard to know what is required as an argument to this method without knowing its internal workings. Should this be called log_stdout? with the argument having a default? In the current format you could pass a 1 or yes as an argument and it would still work. Passing no would also be treated as a true Is that expected behavior?
|
Checked commit bzwei@ae02659 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
The playbook runner now accepts an option
log_outputthat specifies how to write stdout of an Ansible playbook to the log. The option is one ofalways,on_error, andnever.