Add log_output option for embedded ansible service #16414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label enhancement @tinaafitz do we have a BZ for this feature? May use the same BZ for UI work. |
mkanoor
reviewed
Nov 7, 2017
| @@ -163,4 +164,15 @@ def decrypt_options(opts) | |||
| opts[:extra_vars].transform_values! { |val| val.kind_of?(String) ? MiqPassword.try_decrypt(val) : val } | |||
| end | |||
| end | |||
|
|
|||
| def log_stdout(action) | |||
| log_option = options.fetch_path(:config_info, action.downcase.to_sym, :log_output) | |||
There was a problem hiding this comment.
@bzwei do we need a default value of on_error so it would work with existing entities?
There was a problem hiding this comment.
default here is not to log. The true default is expected to be set by the template definition which comes from UI.
|
@bzwei I created new BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1510637 |
bzwei
force-pushed
the
embedded_stdout
branch
from
e284816
to
8f5bbcb
Compare
bzwei
force-pushed
the
embedded_stdout
branch
from
8f5bbcb
to
5d20559
Compare
|
Checked commit bzwei@5d20559 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
mkanoor
approved these changes
Nov 8, 2017
simaishi
pushed a commit
that referenced
this pull request
Nov 14, 2017
Add log_output option for embedded ansible service (cherry picked from commit 4e662a1) https://bugzilla.redhat.com/show_bug.cgi?id=1511977
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #16333, accept
log_outputoption to control whether log ansible stdout in evm.log while executing an embedded ansible service.