[WIP] Tests unique_within_region with class that uses STI #16740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-m-u
force-pushed
the
fix_for_issue_16739
branch
from
9863187
to
2e8e038
Compare
d-m-u
changed the title
d-m-u
force-pushed
the
fix_for_issue_16739
branch
from
2e8e038
to
b7dc603
Compare
d-m-u
changed the title
|
@miq-bot add_label core |
gmcculloug
reviewed
Jan 8, 2018
| context "two pxe templates" do | ||
| it "raises error with non-unique names" do | ||
| expect { @template = FactoryGirl.create(:customization_template, :name => "template") }.to_not raise_error | ||
| expect { @template1 = FactoryGirl.create(:customization_template, :name => @template.name) } |
There was a problem hiding this comment.
@template1 is not used. You can remove.
d-m-u
force-pushed
the
fix_for_issue_16739
branch
6 times, most recently
from
b8e33d0
to
2ad96cd
Compare
d-m-u
force-pushed
the
fix_for_issue_16739
branch
3 times, most recently
from
b04a4e9
to
ec2aaf4
Compare
No, but I would expect that creating two separate leaf classes with the same name should probably fail the uniqueness check as well. |
d-m-u
changed the title
d-m-u
force-pushed
the
fix_for_issue_16739
branch
3 times, most recently
from
5c2adef
to
093b3f5
Compare
d-m-u
force-pushed
the
fix_for_issue_16739
branch
from
093b3f5
to
4d907dd
Compare
d-m-u
changed the title
d-m-u
force-pushed
the
fix_for_issue_16739
branch
from
4d907dd
to
b8402fa
Compare
|
Checked commit d-m-u@b8402fa with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a concern that the CustomizationTemplate class uses STI and thus the unique_within_region validation (that currently uses record.class) being applied to it may not properly scope across leaf classes. The suggestion was to use record.class.base_class instead.
Depends on
#16775