Compare decimal columns correctly in batch saver

[cben]

Extracted from #16722. Will allow container_quota_items.quota_* decimal columns to be used in manager_ref.

@Ladas Thanks for pointers last week! Please review.
cc @agrare

https://bugzilla.redhat.com/show_bug.cgi?id=1504560
@miq-bot add-label enhancement, gaprindashvili/yes

[cben]

Initially I thought this unnecessary, but then I wrote the test and it failed with {:saver_strategy=>:batch, :use_ar_object=>true}
(duh, that's the one container refresh tests don't exercise 😉).
Turns out map_ids_to_inventory_objects ignores use_ar_object and takes values from DB directly anyway (unless it has to use fallback query mode, with unrelated conditions).
So I set deserializable_keys in use_ar_object mode too.
Should I rewrite map_ids_to_inventory_objects to check use_ar_object?

[Ladas]

Should I rewrite map_ids_to_inventory_objects to check use_ar_object?

Yeah, sound like we have to do it. And we should add 'use_ar_object' to containers specs.

[miq-bot]

Checked commit cben@500fb84 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
5 files checked, 8 offenses detected

spec/models/manager_refresh/save_inventory/saver_strategies_spec.rb

• ❗ - Line 220, Col 13 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 221, Col 13 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 223, Col 13 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 226, Col 13 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 278, Col 13 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 279, Col 13 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 280, Col 13 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 281, Col 13 - Naming/VariableNumber - Use normalcase for variable numbers.

[Ladas]

looks good

@agrare the point is to do simple backportable change for now. For upstream we will refactor this to more generic solution. Problem is that the generic solution will be slower, so it would be nice if we could enable the parallel saving.

[Ladas]

@miq-bot assign @agrare

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit 6864c7f34a52560658448dd73bd4ee66e245a8f3
Author: Adam Grare <agrare@redhat.com>
Date:   Mon Feb 26 09:38:22 2018 -0500

    Merge pull request #17020 from cben/deserializable_keys
    
    Compare decimal columns correctly in batch saver
    (cherry picked from commit d3f73488d6fc9ad878ae9192c5437ba6916d588e)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1559544

[agrare]

@cben this caused issues in the G-branch ref due to depending on some of the refactoring that @Ladas did in master that is not in gaprindashvili

[simaishi]

After discussing with @agrare, reverted the backport from Gaprindashvili branch.

commit 9eab6ed7184247107950a79187c496e80f5e3026
Author: Satoe Imaishi <simaishi@redhat.com>
Date:   Fri Mar 23 14:24:35 2018 -0400

    Revert "Merge pull request #17020 from cben/deserializable_keys"
    
    This reverts commit 6864c7f34a52560658448dd73bd4ee66e245a8f3.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1559544

[simaishi]

Marking as conflict for now.

[simaishi]

Backported to Gaprindashvili via #17214