[Gaprindashvili] Fix saver strategies spec #17194
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow association to be nil and always stringify reference. Not defined association should be nil not []. Reference for db_strategy needs to be stringified for g.
In g release, lazy_find accepts only string
|
Checked commits Ladas/manageiq@f77019a~...86a18b4 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
This pull request is not mergeable. Please rebase and repush. |
|
@cben this is what I had to change to make the specs pass All we really need to do is lazy_find(whatever.to_s) and to define :association. I'll send the fix for association being set to nil to upstream first. |
|
Cool. Sounds like you got it covered? Let me know if I can help. |
|
hmm, if lazy_find accepts only strings, how will BigDecimals work? UPDATE: #17214 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few tweaks that were refactored upstream, we need for passin g-release specs, after backporting https://github.com/ManageIQ/manageiq/pull/17020/files#diff-cd53f672c80e0bcb003c0fb0dd75bf05R223
Fixes the failed CI