Fix Default log level for automation log #17130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to a7ed2cb, all loggers would have defaulted to `INFO` with or without the multicast logger. The bug that was fixed in that case is allowing the multicast logger to convert the logger into `DEBUG` mode. Unfortunately, two loggers weren't a part of the list of loggers that then have user settings applied to them to change their default log level: - $miq_ae_logger - $policy_log Since both have been assumed to be `INFO` in the past, this change makes that return to the previous behavior by default, and also has the added bonus of allowing the user to change these settings via the config. Of note, the $policy_log was not the original target of the BZ that prompted this change, but was added since it might also end up causing issues down the road. BZ link: https://bugzilla.redhat.com/show_bug.cgi?id=1553813
Ala Brandon
|
@miq-bot assign @gmcculloug |
|
@NickLaMuro Cannot apply the following label because they are not recognized: automation |
|
Checked commits NickLaMuro/manageiq@5fbb43e~...3626e94 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
|
bdunne
approved these changes
Mar 9, 2018
|
Wow... I hope @bdunne didn't get too excited about the alphabetical change and overlook the true intention of the PR 😏 |
|
No, I saw the full intent of the PR 😄 |
Merged
Merged
simaishi
pushed a commit
that referenced
this pull request
Mar 12, 2018
…ation_logger Fix Default log level for automation log (cherry picked from commit ca25c15) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1553924
|
Backported this PR + #17136. Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
level_automationandlevel_policy(not needed, will explain below)Vmdb::Logger.apply_configon the$miq_ae_loggerand$policy_logconfig/settings.ymlVmdb::Logger.apply_configRegarding the "not needed" part, the method
Vmdb::Logger.apply_config_valuemethod can actually be called without the config value be present in the config and still would default toINFO, which is what we are looking for (this is already done with the$datawarehouse_logfor example). I was unaware of this until doing the second commit in this PR, so I could see a case of not adding these settings for simplicityAlso, the second commit is completely pedantic and optional (I have no problem rebasing it out if that is prefered), but I figured that @bdunne would have eventually done it at some point anyway, so I figured I would get it out of the way.
That said, I did leave the
evm.logandrails.logat the top since I figured that those were of more importance in most cases.Links
Steps for Testing/QA
If you run a automation task, the default log output should not show any
[DEBUG]lines