Alphabets are hard... #17136
Merged
Alphabets are hard... #17136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Yes kids, the letter 'w' does indeed come after the letter 'v'. Take notes, because this will be on your exam and useful in your future careers."
|
cc @bdunne @simaishi @gmcculloug ... anyone else who wants to mock an ridicule me to end your Friday. |
|
Checked commit NickLaMuro@833f6b0 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@simaishi This PR goes along with PR #17130 for BZ https://bugzilla.redhat.com/show_bug.cgi?id=1553813 when back-porting. |
|
Combining into #17130 for backport. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I "dunne" goofed and in #17130 put the
websocketslog prior to the logs lines for the ones starting with "v"... so shameful...That said, I put 90% of the blame on @bdunne for not catching my mistake in the first place and merging just because I alphabetized some code for him (that is my story and I am sticking to it)
Links
Steps for Testing/QA