Renamed method to delete cloud object store for consistency reasons

[romanblanco]

Renamed method introduced in 81072dbb020#diff-ddea025797d4c84804a87a85c2db89a8R4 for consistency reasons.

The change allows me to generalize the case statement introduced in https://github.com/ManageIQ/manageiq-ui-classic/pull/498/files/524fe8c31aecc5becabedc4db880987214aeb240#r106942728

Links

• Renamed method for consistency reasons manageiq-providers-amazon#419
• Generalized case statement so it responds to the method change in the core manageiq-ui-classic#3607

cc @miha-plesko

[miq-bot]

Checked commit romanblanco@edd5c8d with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

[miha-plesko]

I'm missing a link to the commit on UI here (where you use the new function name instead the old one). Other than that I think it should work out of the box, without modifying anything but this unit test on the Amazon repo: https://github.com/ManageIQ/manageiq-providers-amazon/blob/94cfa257daafab041074eb30f27794159736d3d8/spec/models/manageiq/providers/amazon/storage_manager/s3/stubbed_refresher_spec.rb#L217

[romanblanco]

@miha-plesko Thanks, corrected the links, all the PRs should be ready. 👍

[romanblanco]

Getting errors while testing:

I, [2018-03-13T13:43:42.237421 #7613]  INFO -- :   Parameters: {"miq_grid_checks"=>"10000000000031", "pressed"=>"cloud_object_store_object_delete"}
F, [2018-03-13T13:43:42.261153 #7613] FATAL -- : Error caught: [SupportsFeatureMixin::UnknownFeatureError] Feature ':cloud_object_store_object_delete' is unknown to SupportsFeatureMixin.
/home/rblanco/devel/manageiq/app/models/mixins/supports_feature_mixin.rb:159:in `guard_queryable_feature'
/home/rblanco/devel/manageiq/app/models/mixins/supports_feature_mixin.rb:177:in `supports?'
/home/rblanco/devel/manageiq-ui-classic/app/controllers/application_controller/ci_processing.rb:325:in `block in check_supports_task'

Marking this as [WIP] for now.

@miq-bot add_label wip

[romanblanco]

@miq-bot remove_label wip

[kbrock]

looks good. do we need to keep (deprecated) old link in there for a while?

[bronaghs]

@romanblanco - bump

[romanblanco]

@bronaghs Thanks for the reminder 👍

@kbrock I didn't find any other use of the method (see https://github.com/search?q=org%3AManageIQ+delete_cloud_object_store_object&type=Code)

So I believe it is safe just to rename it, and not keeping a link.

[himdel]

manageiq-ui-classic/spec/controllers/application_controller/ci_processing_spec.rb
215:          "delete_cloud_object_store_object",
225:          :task   => "delete_cloud_object_store_object",
228:        controller.send(:process_objects, [object1.id, object2.id], "delete_cloud_object_store_object", "delete")
235:          :task   => "delete_cloud_object_store_object",
292:          "delete_cloud_object_store_object",
302:          :task   => "delete_cloud_object_store_object",
305:        controller.send(:process_objects, [object.id.to_s], "delete_cloud_object_store_object", "delete")
312:          :task   => "delete_cloud_object_store_object",

Those :)

EDIT: fixed by ManageIQ/manageiq-ui-classic#3607