Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renamed method to delete cloud object store for consistency reasons #17143

Merged
merged 1 commit into from
May 7, 2018
Merged

Renamed method to delete cloud object store for consistency reasons #17143

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/models/cloud_object_store_object/operations.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
module CloudObjectStoreObject::Operations
extend ActiveSupport::Concern

def delete_cloud_object_store_object
def cloud_object_store_object_delete
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. do we need to keep (deprecated) old link in there for a while?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@romanblanco - bump

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bronaghs Thanks for the reminder 👍

@kbrock I didn't find any other use of the method (see https://github.com/search?q=org%3AManageIQ+delete_cloud_object_store_object&type=Code)

So I believe it is safe just to rename it, and not keeping a link.

Copy link
Contributor

@himdel himdel May 9, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

manageiq-ui-classic/spec/controllers/application_controller/ci_processing_spec.rb
215:          "delete_cloud_object_store_object",
225:          :task   => "delete_cloud_object_store_object",
228:        controller.send(:process_objects, [object1.id, object2.id], "delete_cloud_object_store_object", "delete")
235:          :task   => "delete_cloud_object_store_object",
292:          "delete_cloud_object_store_object",
302:          :task   => "delete_cloud_object_store_object",
305:        controller.send(:process_objects, [object.id.to_s], "delete_cloud_object_store_object", "delete")
312:          :task   => "delete_cloud_object_store_object",

Those :)

EDIT: fixed by ManageIQ/manageiq-ui-classic#3607

raw_delete
end

Expand Down