Add product files for physical server dashboard widgets #17172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label wip |
miq-bot
changed the title
skovic
force-pushed
the
physical-server-widget-files
branch
from
358d191
to
e90a8d9
Compare
added 4 commits
March 26, 2018 15:29
skovic
force-pushed
the
physical-server-widget-files
branch
from
1ae080b
to
21fe1a9
Compare
skovic
force-pushed
the
physical-server-widget-files
branch
from
21fe1a9
to
bbf84bf
Compare
|
@miq-bot remove_label wip |
miq-bot
changed the title
|
@miq-bot add_label providers/physical |
|
@agrare Can you take a look at this PR when you get a chance? Thanks |
|
@skovic can you address the spec failures? |
skovic
force-pushed
the
physical-server-widget-files
branch
from
a365613
to
6f4a563
Compare
|
@agrare The tests pass now. Thanks |
gtanzillo
suggested changes
Apr 9, 2018
app/models/physical_server.rb
Outdated
| @@ -27,6 +27,9 @@ class PhysicalServer < ApplicationRecord | |||
|
|
|||
| scope :with_hosts, -> { where("physical_servers.id in (select hosts.physical_server_id from hosts)") } | |||
|
|
|||
| virtual_column :v_availability, :type => :string | |||
There was a problem hiding this comment.
You should add :uses => :host to both of these lines to force eager loading. This'll prevent n+1 queries when the widgets are generated.
|
Checked commits skovic/manageiq@16d2ce1~...fbc1e4d with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the product files needed for the new physical server dashboard widgets.