-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add product files for physical server dashboard widgets #17172
Merged
gtanzillo
merged 10 commits into
ManageIQ:master
from
skovic:physical-server-widget-files
Apr 9, 2018
Merged
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
16d2ce1
Add product files for physical server dashboard widgets
e90a8d9
Add physical server health dashboard widget
25ca56b
Add physical server utilization dashboard widget
5960fc9
Update the description of the chart_server_utilization widget
8c3ce22
Clean up new physical server widget product files
f6fb0f3
Changed the server utilization widget into the server availability wi…
bbf84bf
Remove changes made to the dashboard default.yaml file
29aa578
Remove unneeded include from the server availability yaml file
6f4a563
Update MiqReport count in spec test
fbc1e4d
Address initial review feedback
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
description: chart_server_availability | ||
title: "Physical Server Availability" | ||
content_type: chart | ||
options: | ||
:timezone_matters: false | ||
visibility: | ||
:roles: | ||
- _ALL_ | ||
user_id: | ||
resource_name: Physical Server Availability | ||
resource_type: MiqReport | ||
miq_schedule_options: | ||
:run_at: | ||
:interval: | ||
:value: "1" | ||
:unit: hourly | ||
enabled: true | ||
read_only: true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
description: chart_server_health | ||
title: "Physical Server Health" | ||
content_type: chart | ||
options: | ||
:timezone_matters: false | ||
visibility: | ||
:roles: | ||
- _ALL_ | ||
user_id: | ||
resource_name: Physical Server Health | ||
resource_type: MiqReport | ||
miq_schedule_options: | ||
:run_at: | ||
:interval: | ||
:value: "1" | ||
:unit: hourly | ||
enabled: true | ||
read_only: true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
description: rss_newest_servers | ||
title: "Recently Discovered Physical Servers" | ||
content_type: report | ||
options: | ||
:row_count: 5 | ||
visibility: | ||
:roles: | ||
- _ALL_ | ||
user_id: | ||
resource_name: Recently Discovered Physical Servers | ||
resource_type: MiqReport | ||
miq_schedule_options: | ||
:run_at: | ||
:interval: | ||
:value: "1" | ||
:unit: hourly | ||
enabled: true | ||
read_only: true |
54 changes: 54 additions & 0 deletions
54
product/reports/190_Configuration Management - Physical Servers/010_Newest Servers.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
--- | ||
title: Recently Discovered Physical Servers | ||
rpt_group: Custom | ||
rpt_type: Custom | ||
priority: | ||
db: PhysicalServer | ||
cols: | ||
- hostname | ||
- health_state | ||
- power_state | ||
- product_name | ||
include: {} | ||
col_order: | ||
- hostname | ||
- health_state | ||
- power_state | ||
- product_name | ||
headers: | ||
- Hostname | ||
- Health State | ||
- Power State | ||
- Product Name | ||
conditions: | ||
order: Ascending | ||
sortby: | ||
- hostname | ||
group: | ||
graph: | ||
dims: | ||
filename: | ||
file_mtime: | ||
categories: [] | ||
timeline: | ||
template_type: report | ||
where_clause: | ||
db_options: {} | ||
generate_cols: | ||
generate_rows: | ||
col_formats: | ||
- | ||
- | ||
- | ||
- | ||
- | ||
- | ||
tz: | ||
time_profile_id: | ||
display_filter: | ||
col_options: {} | ||
rpt_options: | ||
:pdf: | ||
:page_size: US-Letter | ||
:queue_timeout: | ||
menu_name: Recently Discovered Physical Servers |
36 changes: 36 additions & 0 deletions
36
product/reports/190_Configuration Management - Physical Servers/020_Server Health.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
--- | ||
title: Physical Server Health | ||
conditions: | ||
order: Ascending | ||
graph: | ||
:type: Pie | ||
:count: 10 | ||
:other: true | ||
menu_name: Physical Server Health | ||
rpt_group: Custom | ||
rpt_type: Custom | ||
priority: | ||
col_order: | ||
- hostname | ||
- health_state | ||
- power_state | ||
- product_name | ||
timeline: | ||
file_mtime: | ||
categories: | ||
filename: | ||
db: PhysicalServer | ||
cols: | ||
- hostname | ||
- health_state | ||
- power_state | ||
- product_name | ||
template_type: report | ||
sortby: | ||
- health_state | ||
- hostname | ||
headers: | ||
- Hostname | ||
- Health State | ||
- Power State | ||
- Product Name |
41 changes: 41 additions & 0 deletions
41
product/reports/190_Configuration Management - Physical Servers/030_Server Availability.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
--- | ||
title: Physical Server Availability | ||
order: Ascending | ||
graph: | ||
:type: Pie | ||
:count: 10 | ||
:other: true | ||
menu_name: Physical Server Availability | ||
rpt_group: Custom | ||
rpt_type: Custom | ||
priority: | ||
col_order: | ||
- hostname | ||
- v_availability | ||
- health_state | ||
- power_state | ||
- v_host_os | ||
- product_name | ||
timeline: | ||
file_mtime: | ||
categories: | ||
filename: | ||
db: PhysicalServer | ||
cols: | ||
- hostname | ||
- v_availability | ||
- health_state | ||
- power_state | ||
- v_host_os | ||
- product_name | ||
template_type: report | ||
sortby: | ||
- v_availability | ||
- hostname | ||
headers: | ||
- Hostname | ||
- Availability | ||
- Health State | ||
- Power State | ||
- Host OS | ||
- Product Name |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
describe MiqReport do | ||
context "Seeding" do | ||
include_examples(".seed called multiple times", 140) | ||
include_examples(".seed called multiple times", 143) | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should add
:uses => :host
to both of these lines to force eager loading. This'll prevent n+1 queries when the widgets are generated.