Add CustomAttribute#name validation #17372
Conversation
|
Checked commit bdunne@49a117c with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 spec/models/custom_attribute_spec.rb
|
|
@miq-bot add_label blocker |
|
@JPrause Why is this being labeled as a blocker? As the tests point out, it actually breaks current implementation of several features. |
| @@ -4,6 +4,8 @@ class CustomAttribute < ApplicationRecord | |||
| belongs_to :resource, :polymorphic => true | |||
| serialize :serialized_value | |||
|
|
|||
| validates :name, :format => {:with => /\A[\p{Alpha}_][\p{Alpha}_\d\$]*\z/, :message => "must begin with a letter (a-z, but also letters with diacritical marks and non-Latin letters) or an underscore (_). Subsequent characters can be letters, underscores, digits (0-9), or dollar signs ($)"} | |||
There was a problem hiding this comment.
I wish validation messages showed the tested string, it's not clear what failed in the tests... you have to go to the test and find what name we're providing...
Validation failed: Name must begin with a letter (a-z, but also letters with diacritical marks and non-Latin letters) or an underscore (_). Subsequent characters can be letters, underscores, digits (0-9), or dollar signs ($)
|
@JPrause Yeah, this isn't a blocker since I opened this issue. I'm not even sure we can backport to gaprindashvili directly since it might break other features. We probably would have to deprecate it unless we know it won't break things. |
|
The associated BZ is a blocker. |
|
This doesn't appear to be the way we want to go about fixing this. We should probably make sure that consumers of these attributes are able to handle the various cases of special characters in the attribute names. |
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1558618