Deprecate invalid custom attribute names #18538
Conversation
add_custom_attribute/miq_custom_set will now log a deprecation if we try to define or add a custom attribute name that is an invalid column name. https://bugzilla.redhat.com/show_bug.cgi?id=1662319 From: https://www.postgresql.org/docs/current/static/sql-syntax-lexical.html#SQL-SYNTAX-IDENTIFIERS SQL identifiers and key words must begin with a letter (a-z, but also letters with diacritical marks and non-Latin letters) or an underscore (_). Subsequent characters in an identifier or key word can be letters, underscores, digits (0-9), or dollar signs ($). Note that dollar signs are not allowed in identifiers according to the letter of the SQL standard, so their use might render applications less portable. The SQL standard will not define a key word that contains digits or starts or ends with an underscore, so identifiers of this form are safe against possible conflict with future extensions of the standard. Similar to https://bugzilla.redhat.com/show_bug.cgi?id=1558618
|
Checked commit jrafanie@eaad9fb with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 spec/models/mixins/custom_attribute_mixin_spec.rb
|
jrafanie
changed the title
|
Adding @agrare and @tinaafitz to review since this will now log deprecations on refreshes/automate that try to create custom attributes with "non-column" characters such as spaces. We will eventually want automate/providers refreshes to either reject these or clean them up so they can be used in reporting, expressions, UI, like any other column. Currently, custom attributes coming from refresh/automate with spaces do not work in all areas of the product. |
|
@tinaafitz @agrare please review, thanks! |
|
Looks good to me, refresh doesn't use these accessors so we'll need to check these, cc @Ladas |
…s_in_custom_attributes Deprecate invalid custom attribute names
jrafanie
deleted the
deprecate_invalid_column_names_in_custom_attributes
branch
|
@jrafanie if this can be backported, can you add the hammer/yes label. |
…s_in_custom_attributes Deprecate invalid custom attribute names (cherry picked from commit a26aa9d) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1693722
|
Hammer backport details: |
add_custom_attribute/miq_custom_set will now log a deprecation if we try
to define or add a custom attribute name that is an invalid column name.
https://bugzilla.redhat.com/show_bug.cgi?id=1662319
From:
https://www.postgresql.org/docs/current/static/sql-syntax-lexical.html#SQL-SYNTAX-IDENTIFIERS
SQL identifiers and key words must begin with a letter (a-z, but also
letters with diacritical marks and non-Latin letters) or an underscore
(_). Subsequent characters in an identifier or key word can be letters,
underscores, digits (0-9), or dollar signs ($). Note that dollar signs
are not allowed in identifiers according to the letter of the SQL
standard, so their use might render applications less portable. The SQL
standard will not define a key word that contains digits or starts or
ends with an underscore, so identifiers of this form are safe against
possible conflict with future extensions of the standard.
Similar to https://bugzilla.redhat.com/show_bug.cgi?id=1558618