Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate invalid custom attribute names #18538

Commits on Mar 8, 2019

  1. Deprecate invalid custom attribute names

    add_custom_attribute/miq_custom_set will now log a deprecation if we try
    to define or add a custom attribute name that is an invalid column name.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1662319
    
    From:
    https://www.postgresql.org/docs/current/static/sql-syntax-lexical.html#SQL-SYNTAX-IDENTIFIERS
    
    SQL identifiers and key words must begin with a letter (a-z, but also
    letters with diacritical marks and non-Latin letters) or an underscore
    (_). Subsequent characters in an identifier or key word can be letters,
    underscores, digits (0-9), or dollar signs ($). Note that dollar signs
    are not allowed in identifiers according to the letter of the SQL
    standard, so their use might render applications less portable. The SQL
    standard will not define a key word that contains digits or starts or
    ends with an underscore, so identifiers of this form are safe against
    possible conflict with future extensions of the standard.
    
    Similar to https://bugzilla.redhat.com/show_bug.cgi?id=1558618
    jrafanie committed Mar 8, 2019
    Configuration menu
    Copy the full SHA
    eaad9fb View commit details
    Browse the repository at this point in the history