Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid off query "All in One" in Chargeback #17552

Merged
merged 5 commits into from
Jun 14, 2018
Merged

Get rid off query "All in One" in Chargeback #17552

merged 5 commits into from
Jun 14, 2018

Conversation

lpichler
Copy link
Contributor

@lpichler lpichler commented Jun 7, 2018 •
edited
Loading

Depends on:

second part of the BZ

Links

https://bugzilla.redhat.com/show_bug.cgi?id=1566452

#17538 - first part
#17552 - second part
#17558 - third part - Can be merged before first and second part
#17560 - last part

@miq-bot miq-bot added the wip label Jun 7, 2018
This was referenced Jun 7, 2018
Merged
Merged
@JPrause
Copy link
Member

JPrause commented Jun 11, 2018

@miq-bot add_label blocker

1 similar comment
@JPrause
Copy link
Member

JPrause commented Jun 11, 2018

@miq-bot add_label blocker

@miq-bot
Copy link
Member

miq-bot commented Jun 13, 2018

This pull request is not mergeable. Please rebase and repush.

@miq-bot
Copy link
Member

miq-bot commented Jun 14, 2018

Checked commits lpichler/manageiq@61ceeb5~...e5b6698 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. ⭐

@lpichler lpichler changed the title [WIP] Get rid off query "All in One" in Chargeback Get rid off query "All in One" in Chargeback Jun 14, 2018
@miq-bot miq-bot removed the wip label Jun 14, 2018
@JPrause
Copy link
Member

JPrause commented Jun 14, 2018

@lpichler if this can be backported, please add the gaprindashvili/yes label.

@lpichler
Copy link
Contributor Author

lpichler commented Jun 14, 2018 •
edited
Loading

@JPrause we would like to mark all PRs when all PRs will be merged to upstream.

@gtanzillo gtanzillo self-assigned this Jun 14, 2018
@gtanzillo gtanzillo added this to the Sprint 88 Ending Jun 18, 2018 milestone Jun 14, 2018
@gtanzillo gtanzillo merged commit 019d2ad into ManageIQ:master Jun 14, 2018
@lpichler lpichler mentioned this pull request Jun 15, 2018
Closed
6 tasks
@lpichler
Copy link
Contributor Author

@miq-bot add_label gaprindashvili/yes

@lpichler lpichler deleted the get_rid_off_big_query branch June 15, 2018 09:58
simaishi pushed a commit that referenced this pull request Jun 15, 2018
@gtanzillo @simaishi
Merge pull request #17552 from lpichler/get_rid_off_big_query
d3719f3 
Get rid off query "All in One" in Chargeback
(cherry picked from commit 019d2ad)

https://bugzilla.redhat.com/show_bug.cgi?id=1591939
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit d3719f36ec51e530e19c169449861160601b0344
Author: Gregg Tanzillo <gtanzill@redhat.com>
Date:   Thu Jun 14 09:22:45 2018 -0400

    Merge pull request #17552 from lpichler/get_rid_off_big_query
    
    Get rid off query "All in One" in Chargeback
    (cherry picked from commit 019d2ad8bffc6afdcfc0d468ca7396a34ad92604)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1591939

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtanzillo gtanzillo gtanzillo approved these changes

Assignees

@gtanzillo gtanzillo

Labels
blocker core/chargeback gaprindashvili/backported performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lpichler @JPrause @miq-bot @simaishi @gtanzillo