Use pluck on metric rollup query in chargeback #17560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpichler
changed the title
This was referenced Jun 8, 2018
|
@lpichler if this can be backported, please add the gaprindashvili/yes label |
|
@miq-bot add_label blocker |
|
This pull request is not mergeable. Please rebase and repush. |
lpichler
force-pushed
the
use_pluck_metric_rollup_query_in_chargeback
branch
2 times, most recently
from
ad79e6f
to
21cc480
Compare
|
@lpichler where does this PR stand. |
|
This pull request is not mergeable. Please rebase and repush. |
…Field GOAL: ConsumptionHistory is receiving array of values(got by pluck method) instead of array MetricRollups This commit - this will be method used as argument in pluck method for base MetricRollup query - add @rollup_array to keep array of values which will be used in calculations instead of array MetricRollups - sort list of columns
…onsumptionWithRollups - also add self.col_index(column) as help method to access proper column from array of values - resource_tag_names and all_tag_names don't removed yet from Metric::ChargebackHelper because there is still usage in this helper
…sumptionWithRollups
lpichler
force-pushed
the
use_pluck_metric_rollup_query_in_chargeback
branch
from
21cc480
to
541dfe7
Compare
lpichler
changed the title
1 task
|
Checked commits lpichler/manageiq@9262bf5~...a4579d6 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
6 tasks
|
@lpichler where does this PR stand. Will it be able to be merged today? |
|
@JPrause yes, @gtanzillo is about to merge it. |
|
@miq-bot add_label gaprindashvili/yes |
gtanzillo
approved these changes
Jun 15, 2018
simaishi
pushed a commit
that referenced
this pull request
Jun 15, 2018
…_in_chargeback Use pluck on metric rollup query in chargeback (cherry picked from commit 8180f01) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1591939
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #17592
Stop use AR collection in ConsumptionWithRollups.
Links [Optional]
https://bugzilla.redhat.com/show_bug.cgi?id=1566452
fifth part of fix