locale:po_to_json: add support for including catalogs from javascript plugins

[mzazrivec]

When creating gettext catalogs for javascript consumption, we need to merge catalogs from all ManageIQ plugins and convert the result into a json file. So far, we were only able to do that for regular rails engines (i.e. ManageIQ ruby plugins). As things are, we need to include javascript plugins (such as ui-compoments) into the equation as well.

This change makes it possible to download the gettext catalogs from plugins and include them into the merge & conversion process.

@himdel review please?

@miq-bot add_label gaprindashvili/yes

[mzazrivec]

I'll create a separate PR for gaprindashvili.

@miq-bot remove_label gaprindashvili/yes
@miq-bot add_label gaprindashvili/no

[himdel]

This should probably use system! (from ManageIQ::Environment)

Right now, all the urls create a file saying: "404: Not Found" and get happily ignored

[mzazrivec]

Fixed. And also added an ensure block at the end of the task (the file deletion part).

[miq-bot]

Checked commit mzazrivec@60bac82 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 8 offenses detected

lib/tasks/locale.rake

• ❗ - Line 196, Col 15 - Rails/FilePath - Please use Rails.root.join('path', 'to') instead.
• ❗ - Line 197, Col 15 - Rails/FilePath - Please use Rails.root.join('path', 'to') instead.
• ❗ - Line 220, Col 21 - Rails/FilePath - Please use Rails.root.join('path', 'to') instead.
• ❗ - Line 221, Col 30 - Style/NumericLiteralPrefix - Use 0o for octal literals.
• ❗ - Line 235, Col 22 - Rails/FilePath - Please use Rails.root.join('path', 'to') instead.
• ❗ - Line 236, Col 31 - Style/NumericLiteralPrefix - Use 0o for octal literals.
• ❗ - Line 237, Col 16 - Performance/HashEachMethods - Use each_key instead of keys.each.
• ❗ - Line 240, Col 24 - Style/NumericLiteralPrefix - Use 0o for octal literals.

[himdel]

Looks like it now handles failures just fine:

himdel@thror:~/manageiq$ be rake locale:po_to_json
** override_gem: manageiq-ui-classic, [{:path=>"/home/himdel/manageiq-ui-classic"}], caller: /home/himdel/manageiq/bundler.d/Gemfile.dev.rb
** Using session_store: ActionDispatch::Session::MemCacheStore
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 404 Not Found

== Command ["curl -f -o /home/himdel/manageiq/locale/plugins/ui-components/en/ui-components.po https://raw.githubusercontent.com/ManageIQ/ui-components/master/locale/en/ui-components.po"] failed in /home/himdel/manageiq ==

himdel@thror:~/manageiq$ ls locale/
en  en.yml  es  es.yml  fr  fr.yml  ja  ja.yml  manageiq.pot  zanata.xml  zh_CN  zh_CN.yml

👍

[himdel]

Aand now that the files exist (ManageIQ/ui-components#327), confirmed I can see the strings in my manageiq-ui-classic/app/assets/javascripts/locale/en/app.js 👍

[simaishi]

Backported to Gaprindashvili via #17740