Remove unused code. If we need it, it can be brought back. #21802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
js_plugins is empty so this is a no-op right now. This code is already complicated enough, let's remove this and add it if we actually get po files form js plugins.
|
✂️ 🔥 ✂️ 🔥 ✂️ 🔥 🍰 🍪 👏 🙇 😍 🎉 |
|
Checked commit jrafanie@b6b18ca with ruby 2.6.7, rubocop 1.19.1, haml-lint 0.35.0, and yamllint |
|
I'm trying to walk this back to understand why it's empty, when it didn't used to be, even though we still use ui-components. However, I don't think we use react-ui-components anymore. So, going backwards
|
|
I'm gonna merge this since the code hasn't been used in a while and clearly things still work :) |
|
Backported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
js_plugins is empty so this is a no-op right now. This code is already
complicated enough, let's remove this and add it if we actually get po files
from js plugins.