Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Gaprindashvili] Backport Admin report and request roles #17858

Closed
wants to merge 7 commits into from
Closed

[Gaprindashvili] Backport Admin report and request roles #17858

wants to merge 7 commits into from

Commits on Aug 16, 2018

  1. Add miq_product_features to miq_group through miq_user_role

    @kbrock
    Jillian Tullo authored and kbrock committed Aug 16, 2018
    Configuration menu
    Copy the full SHA
    d565727 View commit details
    Browse the repository at this point in the history

  2. use :role instead of :name for role specs

    @kbrock
    kbrock committed Aug 16, 2018
    Configuration menu
    Copy the full SHA
    e31741f View commit details
    Browse the repository at this point in the history

  3. move disallowed_roles calculation to rbac

    @kbrock
    kbrock committed Aug 16, 2018
    Configuration menu
    Copy the full SHA
    7a9a709 View commit details
    Browse the repository at this point in the history

  4. User#with_current_user_groups -> with_groups 

    move hardcoded admin logic over to rbac
    @kbrock
    kbrock committed Aug 16, 2018
    Configuration menu
    Copy the full SHA
    41569d3 View commit details
    Browse the repository at this point in the history

  5. use features to check if a role is an admin role 

    the role name used to determine if it were

https://bugzilla.redhat.com/show_bug.cgi?id=1090627
    @kbrock
    kbrock committed Aug 16, 2018
    Configuration menu
    Copy the full SHA
    1492fb7 View commit details
    Browse the repository at this point in the history

  6. separate report and request admins 

    Admins have 2 types of escalated privileges
report and request

This separates the types (with 2 different product features)
    @kbrock
    kbrock committed Aug 16, 2018
    Configuration menu
    Copy the full SHA
    7328fb4 View commit details
    Browse the repository at this point in the history

  7. Converge request user roles 

    We introduced feature miq_request_superadmin in f6c02e8 / ManageIQ#17444
The feature miq_request_approval already existed.
Merging the 2 together.

This fixes an inconsistency between API and UI
The issue existed before this feature was introduced
so this works with 17444 to fix the BZ

ManageIQ#17444
https://bugzilla.redhat.com/show_bug.cgi?id=1608554
    @kbrock
    kbrock committed Aug 16, 2018
    Configuration menu
    Copy the full SHA
    ce98d6e View commit details
    Browse the repository at this point in the history