[Gaprindashvili] Backport Admin report and request roles #17858
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbrock
force-pushed
the
bz_1608554-g
branch
3 times, most recently
from
ac7fe9c
to
3eaa5b6
Compare
move hardcoded admin logic over to rbac
the role name used to determine if it were https://bugzilla.redhat.com/show_bug.cgi?id=1090627
Admins have 2 types of escalated privileges report and request This separates the types (with 2 different product features)
We introduced feature miq_request_superadmin in f6c02e8 / ManageIQ#17444 The feature miq_request_approval already existed. Merging the 2 together. This fixes an inconsistency between API and UI The issue existed before this feature was introduced so this works with 17444 to fix the BZ ManageIQ#17444 https://bugzilla.redhat.com/show_bug.cgi?id=1608554
|
Checked commits kbrock/manageiq@d565727~...ce98d6e with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
closing for now - deemed this was not a priority to merge to G
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR manually backports to G:
There were conflicts (especially in filterer and miq_user_role) since #17768 was applied before this PR
Followup PRs to backport:
https://bugzilla.redhat.com/show_bug.cgi?id=1608554