use request_admin_user #4487
Merged
use request_admin_user #4487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use helper method instead of calling out the miq_request_approval role (yes, this is being corrected in this commit) https://bugzilla.redhat.com/show_bug.cgi?id=1608554
2 tasks
|
@miq-bot tag bug rbac |
|
@kbrock unrecognized command 'tag', ignoring... Accepted commands are: add_label, add_reviewer, assign, close_issue, move_issue, remove_label, rm_label, set_milestone |
6 tasks
|
Checked commit kbrock@d4f9835 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
correcting 1 line from #3993
related: ManageIQ/manageiq#17849
This uses a helper method instead of calling out the the
miq_request_approvalrole.(yes, if you notice, this change will effectively change the feature from
miq_request_superadmintomiq_request_approval- since that feature was erroneously introduced.https://bugzilla.redhat.com/show_bug.cgi?id=1608554