[Gaprindashvili] converge UI and API privs for request/report admins

[kbrock]

This is a straightforward backport of #3993 (minor conflict) and #4487 (no conflicts)

This is part of ManageIQ/manageiq#17849 (the G backport version: ManageIQ/manageiq#17849 proper )

https://bugzilla.redhat.com/show_bug.cgi?id=1608554

[miq-bot]

Checked commits kbrock/manageiq-ui-classic@4217f7c~...912f6de with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
11 files checked, 5 offenses detected

app/controllers/application_controller/current_user.rb

• 💣 💥 🔥 🚒 - Line 24, Col 17 - Lint/Syntax - unexpected token error
  (Using Ruby 2.2 parser; configure using TargetRubyVersion parameter, under AllCops)

app/controllers/configuration_controller.rb

• ❗ - Line 191, Col 5 - Style/ConditionalAssignment - Use the return of the conditional for variable assignment and comparison.
• ❗ - Line 257, Col 13 - Style/TernaryParentheses - Omit parentheses for ternary conditions.

app/controllers/report_controller/menus.rb

• ❗ - Line 372, Col 95 - Style/NumericPredicate - Use flg.zero? instead of flg == 0.

spec/helpers/application_helper/buttons/miq_request_delete_spec.rb

• ❗ - Line 15, Col 25 - Layout/ExtraSpacing - Unnecessary spacing detected.

[mzazrivec]

@kbrock Could you please fix the rubocop warnings above? Thanks.

[mzazrivec]

@kbrock The CI failures seem related.

[kbrock]

Thanks @mzazrivec This is dependent upon a ManageIQ/manageiq#17849 that was not merged - and it looks like it will not be merged.

Closing this - we can revisit if priorities change