Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add possibility to group by date only in chargeback #17893

Merged
merged 1 commit into from
Aug 24, 2018
Merged

Add possibility to group by date only in chargeback #17893

merged 1 commit into from
Aug 24, 2018

Conversation

lpichler
Copy link
Contributor

Backend part for ManageIQ/manageiq-ui-classic#4523

Option group by date and by vm had identical behaviour. This PR adds backend part to reach report grouped only per day(vm name is removed):

screen shot 2018-08-22 at 18 48 51

Links

@miq-bot add_label gaprindashvili/yes, chargeback, improvement
@miq-bot assign @gtanzillo

@lpichler lpichler mentioned this pull request Aug 22, 2018
Merged
@miq-bot
Copy link
Member

miq-bot commented Aug 22, 2018

@lpichler Cannot apply the following label because they are not recognized: improvement

@miq-bot
Copy link
Member

miq-bot commented Aug 22, 2018

Checked commit lpichler@44841fa with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 0 offenses detected
Everything looks fine. ⭐

gtanzillo
gtanzillo approved these changes Aug 24, 2018
View reviewed changes
Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gtanzillo gtanzillo added this to the Sprint 93 Ending Aug 27, 2018 milestone Aug 24, 2018
@gtanzillo gtanzillo merged commit f1ee798 into ManageIQ:master Aug 24, 2018
@JPrause
Copy link
Member

JPrause commented Aug 27, 2018

@miq-bot add_label blocker

@JPrause
Copy link
Member

JPrause commented Aug 27, 2018

@lpichler if this can be backported, can you add the gaprindashvili.yes and the fine/yes labels.

@lpichler lpichler deleted the add_date_only_option_to_chargeback branch August 27, 2018 15:27
@lpichler
Copy link
Contributor Author

@miq-bot add_label fine/yes, gaprindashvili/yes

@simaishi
Copy link
Contributor

@lpichler Looks like we don't have the "group by tenants" spec in Fine branch. What do we need to do here?

@lpichler
Copy link
Contributor Author

@simaishi ok, in that case I'll open PR for fine in a while. thanks

@lpichler lpichler mentioned this pull request Aug 27, 2018
Merged
@lpichler
Copy link
Contributor Author

@simaishi fine PR:#17909

@simaishi
Copy link
Contributor

Backported to Fine via #17909

simaishi pushed a commit that referenced this pull request Sep 11, 2018
@gtanzillo @simaishi
Merge pull request #17893 from lpichler/add_date_only_option_to_charg…
19a978a 
…eback

Add possibility to group by date only in chargeback
(cherry picked from commit f1ee798)

https://bugzilla.redhat.com/show_bug.cgi?id=1622631
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 19a978ab5c1227c23d1ceee4227792bda5d90577
Author: Gregg Tanzillo <gtanzill@redhat.com>
Date:   Fri Aug 24 11:25:13 2018 -0400

    Merge pull request #17893 from lpichler/add_date_only_option_to_chargeback
    
    Add possibility to group by date only in chargeback
    (cherry picked from commit f1ee7980adc9caf6451a6b9fa12ae491d9f5ecb6)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1622631

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtanzillo gtanzillo gtanzillo approved these changes

Assignees

@gtanzillo gtanzillo

Labels
blocker core/chargeback fine/backported gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lpichler @miq-bot @JPrause @simaishi @gtanzillo