Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FINE] Add possibily to group by date only in chargeback #17909

Merged
merged 1 commit into from
Aug 27, 2018
Merged

[FINE] Add possibily to group by date only in chargeback #17909

merged 1 commit into from
Aug 27, 2018

Conversation

lpichler
Copy link
Contributor

@lpichler lpichler commented Aug 27, 2018 •
edited by simaishi
Loading

@lpichler lpichler changed the title Add possibily to group by date only in chargeback [FINE] Add possibily to group by date only in chargeback Aug 27, 2018
@lpichler lpichler mentioned this pull request Aug 27, 2018
Merged
gtanzillo
gtanzillo approved these changes Aug 27, 2018
View reviewed changes
Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@miq-bot
Copy link
Member

miq-bot commented Aug 27, 2018

Checked commit lpichler@13ed59f with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 0 offenses detected
Everything looks fine. 🍰

@simaishi simaishi merged commit 72b1cef into ManageIQ:fine Aug 27, 2018
@simaishi simaishi added this to the Sprint 93 Ending Aug 27, 2018 milestone Aug 27, 2018
@simaishi simaishi self-assigned this Aug 27, 2018
@lpichler lpichler deleted the add_date_only_option_to_chargeback_fine branch August 27, 2018 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtanzillo gtanzillo gtanzillo approved these changes

Assignees

@simaishi simaishi

Labels
bug core/chargeback
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lpichler @miq-bot @gtanzillo @simaishi