Add requester to raise_retirement_event log message #17898
Conversation
|
@miq-bot assign @gmcculloug |
|
I don't even know what to label this. |
|
@mkanoor Logging the requester would help tremendously in debugging retirement issues. Please review. |
|
Checked commit d-m-u@04b8cc6 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
| @@ -203,7 +203,7 @@ def retired_event_name | |||
| def raise_retirement_event(event_name, requester = nil) | |||
| requester ||= User.current_user.try(:userid) | |||
| q_options = retire_queue_options | |||
| $log.info("Raising Retirement Event for [#{name}] with queue options: #{q_options.inspect}") | |||
| $log.info("Requester [#{requester}] raising Retirement Event for [#{name}] with queue options: #{q_options.inspect}") | |||
There was a problem hiding this comment.
Just wanted to check since requester could potentially be nil would you want to treat that condition differently or are you ok logging Requester [] raising Retirement Event for...
There was a problem hiding this comment.
@gmcculloug I'm okay with logging nil for the requester
|
@tinaafitz can we backport this to G? Do ... would we want to, I mean? |
|
@d-m-u Yes, I would like to backport this change to the G release. |
|
backport is here: #17944 |
It would be helpful in raise_retirement_event if we also printed the requester.
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1625320