Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GAPRINDASHVILI] Add requester info to log message #17944

Merged
merged 1 commit into from
Oct 16, 2018
Merged

[GAPRINDASHVILI] Add requester info to log message #17944

merged 1 commit into from
Oct 16, 2018

Conversation

d-m-u
Copy link
Contributor

@d-m-u d-m-u commented Sep 4, 2018

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1625320

This is the g/release version of #17898 which adds the requester information to the logging in raise_retirement_event.

@d-m-u
Copy link
Contributor Author

d-m-u commented Sep 4, 2018

@miq-bot assign @gmcculloug
@miq-bot add_label bug
@miq_bot add_reviewer @tinaafitz

@miq-bot miq-bot changed the title Add requester info to log message [GAPRINDASHVILI] Add requester info to log message Sep 4, 2018
@miq-bot miq-bot added the bug label Sep 4, 2018
@miq-bot
Copy link
Member

miq-bot commented Sep 4, 2018

Checked commit d-m-u@ae51ec0 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@gmcculloug gmcculloug assigned simaishi and unassigned gmcculloug Sep 4, 2018
tinaafitz
tinaafitz approved these changes Sep 4, 2018
View reviewed changes
Copy link
Member

@tinaafitz tinaafitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@d-m-u looks good.

@d-m-u
Copy link
Contributor Author

d-m-u commented Sep 6, 2018

@gmcculloug can we merge this please?

@d-m-u d-m-u mentioned this pull request Sep 6, 2018
Merged
@simaishi
Copy link
Contributor

simaishi commented Sep 6, 2018

@d-m-u This PR isn't associated with a BZ that's a blocker for the next G release, so it can't be merged...

@d-m-u
Copy link
Contributor Author

d-m-u commented Sep 6, 2018

It was a good try though.

tinaafitz
tinaafitz approved these changes Oct 16, 2018
View reviewed changes
Copy link
Member

@tinaafitz tinaafitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@d-m-u Looks good.
@mkanoor Please review.

@mkanoor mkanoor merged commit 8ec02d8 into ManageIQ:gaprindashvili Oct 16, 2018
@simaishi
Copy link
Contributor

This isn't approved for the next G release, and shouldn't have been merged... I will have to revert.

simaishi added a commit that referenced this pull request Oct 16, 2018
@simaishi
Revert "Merge pull request #17944 from d-m-u/log_requester"
846d597 
This reverts commit 8ec02d8, reversing
changes made to 5f1530c.
@simaishi
Copy link
Contributor

Reverted.

commit 846d597fbfa47a7afdaa9a06ed6a686752a152e8
Author: Satoe Imaishi <simaishi@redhat.com>
Date:   Tue Oct 16 13:29:20 2018 -0400

    Revert "Merge pull request #17944 from d-m-u/log_requester"
    
    This reverts commit 8ec02d868ccfcffc59a7c9577600e16c7ea5ec6a, reversing
    changes made to 5f1530c959dbd7aea3e23f970dace3f24ca1fbe6.

@d-m-u d-m-u deleted the log_requester branch February 1, 2019 20:47
@mfeifer mfeifer added this to the Sprint 97 Ending Oct 22, 2018 milestone Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tinaafitz tinaafitz tinaafitz approved these changes

@gmcculloug gmcculloug gmcculloug approved these changes

@mkanoor mkanoor mkanoor approved these changes

Assignees

@simaishi simaishi

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@d-m-u @miq-bot @simaishi @tinaafitz @gmcculloug @mkanoor @mfeifer