Dont return different types in virtual columns #18217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PanSpagetka
force-pushed
the
fix-miq-template-virtual-cols
branch
2 times, most recently
from
47255ca
to
ac37579
Compare
|
Still problematic in Infra provisioning:
In Cloud:
|
PanSpagetka
force-pushed
the
fix-miq-template-virtual-cols
branch
from
ac37579
to
b42f1be
Compare
|
Checked commit PanSpagetka@b42f1be with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
Aaand now it works :) Verified that both cloud & infra vm provisioning screens work in the UI together with ManageIQ/manageiq-ui-classic#4509, including sorting by each column 👍 |
|
ping @martinpovolny |
simaishi
pushed a commit
that referenced
this pull request
Nov 27, 2018
Dont return different types in virtual columns (cherry picked from commit ab470a4) https://bugzilla.redhat.com/show_bug.cgi?id=1610927
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix virtual columns introduced in #17884 which is needed for ManageIQ/manageiq-ui-classic#4509
These virtual columns returned different types (Integer/String) and that caused problems when trying to sort by these columns,
Links
https://bugzilla.redhat.com/show_bug.cgi?id=1610927
ManageIQ/manageiq-ui-classic#4509
@himdel Could you please verify this fixes the issue?