Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display deprecated as a true/false string #18237

Merged

Conversation

PanSpagetka
Copy link
Contributor

@PanSpagetka PanSpagetka commented Nov 28, 2018

@himdel
Copy link
Contributor

himdel commented Nov 28, 2018

@miq-bot add_label bug, blocker, hammer/yes

Fixes ManageIQ/manageiq-ui-classic#4509 (comment) 👍

@miq-bot
Copy link
Member

miq-bot commented Nov 28, 2018

Checked commit PanSpagetka@dd08a4e with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@martinpovolny martinpovolny self-assigned this Nov 28, 2018
@martinpovolny martinpovolny merged commit 12ecbe4 into ManageIQ:master Nov 28, 2018
@martinpovolny martinpovolny added this to the Sprint 100 Ending Dec 3, 2018 milestone Nov 28, 2018
simaishi pushed a commit that referenced this pull request Nov 30, 2018
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit 8dd25eb33d45ca3d748c8d3b13738fc78daa69c4
Author: Martin Povolny <mpovolny@redhat.com>
Date:   Wed Nov 28 16:22:16 2018 +0100

    Merge pull request #18237 from PanSpagetka/template-display-bool-string
    
    Display deprecated as a true/false string
    
    (cherry picked from commit 12ecbe4b2945ceb5278a43d95336d70a004bab41)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1610927

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants