Add more robust error handling to ConversionHost#get_conversion_state #18258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djberg96
changed the title
|
@djberg96 thanks. 👍 |
|
This pull request is not mergeable. Please rebase and repush. |
djberg96
changed the title
|
@miq-bot remove_label wip |
|
@miq-bot add_label transformation, refactoring |
|
@miq-bot remove_label unmergeable |
|
Checked commits https://github.com/djberg96/manageiq/compare/a9f82feeb177c29aeba9f86d348f12d9f59b6bc8~...e7482f1795c7d8afa8313d268b744971cbec3cd1 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
agrare
approved these changes
Mar 27, 2019
|
@miq-bot add-label hammer/yes |
simaishi
pushed a commit
that referenced
this pull request
Apr 22, 2019
Add more robust error handling to ConversionHost#get_conversion_state (cherry picked from commit f73e7e6) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1702055
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on a conversation with Kedar Kulkarni, this PR attempts to add some more robust error handling to the
get_conversion_statemethod. At the moment the SFTP download is sometimes failing somehow, so the data stream ends up being blank, which then results in a JSON parser error. This doesn't tell us the "real" error, which I'm hoping to figure out.Original reported at https://bugzilla.redhat.com/show_bug.cgi?id=1653407 (but don't use this)
(The other micro changes you see were already-existent blank spaces that were auto-stripped by my editor, I'm surprised rubocop didn't catch those before).WIP for now as I'm not sure that this will be enough, or if MiqSshUtil (from gems-pending) needs some TLC.https://bugzilla.redhat.com/show_bug.cgi?id=1695847