Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V2V] Add extra error handling for the ConversionHost#run_conversion method #18768

Merged
merged 1 commit into from
May 21, 2019
Merged

[V2V] Add extra error handling for the ConversionHost#run_conversion method #18768

merged 1 commit into from
May 21, 2019

Conversation

djberg96
Copy link
Contributor

@djberg96 djberg96 commented May 15, 2019 •
edited
Loading

This PR adds some extra error handling around the run_conversion method. Specifically it will now differentiate between connection failures, JSON parsing errors and other errors.

Added one very minor formatting tweak to the apply_task_limits error handling, too.

I also added some specs for this methods which was apparently uncovered previously.

Something of a followup to #18258

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1708739

@djberg96 djberg96 changed the title [V2V] Added extra error handling for the ConversionHost#run_conversion method [V2V] Add extra error handling for the ConversionHost#run_conversion method May 15, 2019
@miq-bot
Copy link
Member

miq-bot commented May 15, 2019

Checked commit https://github.com/djberg96/manageiq/commit/cc7c157f46ad0d4f0035ff628126e053c0e51bba with ruby 2.3.3, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 2 offenses detected

app/models/conversion_host.rb

@djberg96
Copy link
Contributor Author

Ignoring these rubocop issues for now, because they chose a dumb default, trying to get the guide updated.

@djberg96
Copy link
Contributor Author

@miq-bot add_label transformation, refactoring

@djberg96
Copy link
Contributor Author

@miq-bot add_label hammer/yes

@djberg96
Copy link
Contributor Author

@miq-bot add_reviewer @agrare

@miq-bot miq-bot requested a review from agrare May 21, 2019 14:22
@agrare agrare self-assigned this May 21, 2019
agrare
agrare approved these changes May 21, 2019
View reviewed changes
Copy link
Member

@agrare agrare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice looks good @djberg96

@agrare agrare merged commit d1ea5d1 into ManageIQ:master May 21, 2019
@agrare agrare added this to the Sprint 112 Ending May 27, 2019 milestone May 21, 2019
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit c9be7bc13c794b51d90c9022f811848c195b00ee
Author: Adam Grare <agrare@redhat.com>
Date:   Tue May 21 15:47:51 2019 -0400

    Merge pull request #18768 from djberg96/conversion_host_json_parsing
    
    [V2V] Add extra error handling for the ConversionHost#run_conversion method
    
    (cherry picked from commit d1ea5d1937b51b1891ead86f007eb238d5cc1639)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1712135

simaishi pushed a commit that referenced this pull request May 22, 2019
@agrare @simaishi
Merge pull request #18768 from djberg96/conversion_host_json_parsing
ec6d2a4 
[V2V] Add extra error handling for the ConversionHost#run_conversion method

(cherry picked from commit d1ea5d1)

https://bugzilla.redhat.com/show_bug.cgi?id=1712135
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrare agrare agrare approved these changes

Assignees

@agrare agrare

Labels
hammer/backported refactoring v2v
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@djberg96 @miq-bot @simaishi @agrare