Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update host switch association #18427

Merged
merged 7 commits into from
Feb 14, 2019
Merged

Update host switch association #18427

merged 7 commits into from
Feb 14, 2019

Conversation

agrare
Copy link
Member

@agrare agrare commented Feb 1, 2019 •
edited
Loading

Fix issues with how switches are associated to hosts and EMSs that required really hacky ways of handling switch deletion (here).

Depends on: ManageIQ/manageiq-schema#232

Dependents:

  1. Parse host.host_switches manageiq-providers-scvmm#104
  2. Add relations for distributed_virtual_switches manageiq-providers-vmware#364
  3. Fixes for host_switches manageiq-providers-ovirt#338

@miq-bot miq-bot added the wip label Feb 1, 2019
@agrare agrare force-pushed the update_host_switch_association branch 3 times, most recently from 9ee3362 to e66150a Compare February 5, 2019 00:56
@agrare agrare requested a review from Ladas February 5, 2019 01:11
@agrare
Copy link
Member Author

agrare commented Feb 5, 2019

cc @Ladas

@agrare agrare force-pushed the update_host_switch_association branch 2 times, most recently from be4565e to 345ad2b Compare February 5, 2019 13:43
@agrare agrare changed the title [WIP] Update host switch association Update host switch association Feb 5, 2019
@agrare agrare removed the wip label Feb 5, 2019
@agrare agrare force-pushed the update_host_switch_association branch 2 times, most recently from 4b9ec6b to edd4c70 Compare February 11, 2019 19:59
@Ladas Ladas mentioned this pull request Feb 12, 2019
Merged
2 tasks
@agrare agrare closed this Feb 13, 2019
@agrare agrare reopened this Feb 13, 2019
@agrare agrare force-pushed the update_host_switch_association branch from edd4c70 to 2cfd0d3 Compare February 13, 2019 19:59
@agrare agrare force-pushed the update_host_switch_association branch from 2cfd0d3 to 582c58e Compare February 13, 2019 20:35
@agrare agrare mentioned this pull request Feb 13, 2019
Merged
@miq-bot
Copy link
Member

miq-bot commented Feb 13, 2019

Checked commits agrare/manageiq@ff9febc~...1d154d3 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
6 files checked, 2 offenses detected

app/models/ems_refresh/save_inventory_infra.rb

This was referenced Feb 14, 2019
Merged
Merged
Ladas
Ladas approved these changes Feb 14, 2019
View reviewed changes
Copy link
Contributor

@Ladas Ladas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gtanzillo gtanzillo added this to the Sprint 105 Ending Feb 18, 2019 milestone Feb 14, 2019
@gtanzillo gtanzillo merged commit edf7f9c into ManageIQ:master Feb 14, 2019
@agrare agrare deleted the update_host_switch_association branch February 14, 2019 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ladas Ladas Ladas approved these changes

Assignees

@gtanzillo gtanzillo

Labels
enhancement providers/infrastructure providers/inventory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@agrare @miq-bot @Ladas @Fryguy @gtanzillo