Don't retire load balancers #18443
Merged
Don't retire load balancers #18443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label bug |
|
We should also remove https://github.com/ManageIQ/manageiq/blob/master/app/models/load_balancer.rb#L5 and check for other retirement references on this object. |
d-m-u
force-pushed
the
remove_lbs_from_retirement_check
branch
from
38eb29b
to
4940668
Compare
tinaafitz
approved these changes
Feb 11, 2019
gmcculloug
approved these changes
Feb 11, 2019
|
@d-m-u if this can be backported, can you add the hammer/yes label. |
|
@miq-bot add_label hammer/yes |
simaishi
pushed a commit
that referenced
this pull request
Feb 18, 2019
Don't retire load balancers (cherry picked from commit d8a6ba0) https://bugzilla.redhat.com/show_bug.cgi?id=1678476
|
Hammer backport details: |
|
sorry, i messed up, this should be hammer/no |
simaishi
added a commit
that referenced
this pull request
Feb 19, 2019
…nt_check" This reverts commit 2aa3228.
|
Reverted the backport: |
d-m-u
added a commit
to d-m-u/manageiq
that referenced
this pull request
Aug 14, 2019
thearifismail
pushed a commit
to thearifismail/manageiq
that referenced
this pull request
Aug 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presently system_context retirement only checks to see if the
evm_owner_idis present on the object, it doesn't check that that id is that of a valid user. In order to make the check run onevm_ownerwe will need to remove load balancers from the list of things to retire in the retirement manager per #18437 (comment) since load balancers don't have owners.Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1673143. (it doesn't fix it but the related PR does and this is required for the related PR)
related to
#18437