Add missing quota tags #18656
Add missing quota tags #18656
Conversation
|
Checked commits jeffmcutter/manageiq@dea4a4a~...c91a13d with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
Can you comment on this? Does it make sense? Thanks, |
There was a problem hiding this comment.
Thanks @jeffmcutter for adding the missing categories and tags.
|
@lfu Please review. |
| - :description: 1GB | ||
| :read_only: "0" | ||
| :syntax: string | ||
| :name: "1024" |
There was a problem hiding this comment.
Why is the name not set the same way as for Quota - Warn Storage?
There was a problem hiding this comment.
@lfu Unfortunately, tags values differ for storage and memory. The tag values from max_storage/warn_storage should match, as well as values for max_memory/warn_memory.
There was a problem hiding this comment.
We can't change the values because it would break existing customers environments.
|
@bdunne Please review. |
|
Hi @tinaafitz @bdunne, Did this get lost or is there an issue? Thanks, |
Automate quota validation is designed to be able to make use of the following tags / tag categories, but they do not exist by default:
Quota - Max VMs
Quota - Warn CPUs
Quota - Warn Memory
Quota - Warn Storage
Quota - Warn VMs