Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Classification seeding :parent_id has been removed #19000

Merged
merged 1 commit into from
Jul 17, 2019

Conversation

bdunne
Copy link
Member

@bdunne bdunne commented Jul 17, 2019

Broken by #18656
#18418 removed :parent_id: 0

Copy link
Member

@jrafanie jrafanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merge when green

@miq-bot
Copy link
Member

miq-bot commented Jul 17, 2019

Checked commit bdunne@c77c2c1 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

@jrafanie jrafanie merged commit e0fedea into ManageIQ:master Jul 17, 2019
@jrafanie jrafanie added test bug and removed test labels Jul 17, 2019
@jrafanie jrafanie added this to the Sprint 116 Ending Jul 22, 2019 milestone Jul 17, 2019
@bdunne bdunne deleted the fix_classification_seeding branch July 17, 2019 18:16
@bdunne bdunne assigned jrafanie and unassigned kbrock Jul 17, 2019
@kbrock
Copy link
Member

kbrock commented Jul 17, 2019

thanks guys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants