Add migration analytics reports #18749
Conversation
|
@miq-bot add_label hammer:yes |
|
@miq-bot add_label Enhancement |
|
@miq-bot add_label z-stream |
|
@pemcg Cannot apply the following label because they are not recognized: hammer:yes |
|
@pemcg Cannot apply the following label because they are not recognized: z-stream |
|
@miq-bot add_label hammer/yes |
…pemcg/manageiq into add_migration_analytics_reports
|
@miq-bot add_label changelog/yes |
There was a problem hiding this comment.
looks good. just the minor thoughtz
@martinpovolny who tends to review these "ui" PRs?
| value: '' | ||
| - "=": | ||
| field: Vm-type | ||
| value: ManageIQ::Providers::Vmware::InfraManager::Vm |
There was a problem hiding this comment.
would it make sense to just do:
db: ManageIQ::Providers::Vmware::InfraManager::VmThere was a problem hiding this comment.
This db object wouldn't be available for a report created using the UI, the only option in the "Base the report on" drop-down is "Virtual Machines". Happy to change, but would that be subsequently copy/editable in the UI at a later stage by a user?
There was a problem hiding this comment.
sigh. it is important to be editable/hackable.
For this one keeping it this way would probably be the same
| exp: | ||
| "=": | ||
| field: Host.ext_management_system-type | ||
| value: ManageIQ::Providers::Vmware::InfraManager |
There was a problem hiding this comment.
think using a Vmware field for the db: host would also be more efficient
There was a problem hiding this comment.
is it possible to put a test on Host-type instead of the join into ems? (not sure if that actually exists)
| rpt_type: Custom | ||
| priority: 10 | ||
| db: Host | ||
| cols: |
There was a problem hiding this comment.
@martinpovolny are we creating reports with cols and include or are we starting to do reports without these optional columns?
There was a problem hiding this comment.
@kbrock : shall we modify the report editor to skip these fields?
There was a problem hiding this comment.
@martinpovolny nah - probably too much work.
Keep these columns in.
| db_options: {} | ||
| generate_cols: | ||
| generate_rows: | ||
| col_formats: |
There was a problem hiding this comment.
also, do we like specifying all these columns to make it easier to copy/paste to a new report, or do we remove fields that are no longer used?
There was a problem hiding this comment.
I guess we should have modified the report editor after you did the changes that made these fields redundant.
product/reports/310_Migration Readiness - Providers/010_VMware Environment Summary.yaml
Outdated
Show resolved
Hide resolved
product/reports/310_Migration Readiness - Providers/010_VMware Environment Summary.yaml
Outdated
Show resolved
Hide resolved
|
Checked commits pemcg/manageiq@31539e8~...ddde500 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
👍 |
Add migration analytics reports (cherry picked from commit 21ec615) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1718916
|
Hammer backport details: |
This PR provides the reports for https://bugzilla.redhat.com/show_bug.cgi?id=1708369
The 2 new reports are:
Migration Readiness/Virtual Machines/VMware VM Summary
Migration Readiness/Providers/VMware Environment Summary