Add ext_management_system.id to Migration Readiness summary reports #18944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fryguy
approved these changes
Jul 8, 2019
|
👍 |
Fryguy
reviewed
Jul 8, 2019
product/reports/310_Migration Readiness - Providers/010_VMware Environment Summary.yaml
Outdated
Show resolved
Hide resolved
|
Checked commits mturley/manageiq@3cb9d9e~...8f143fb with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
LGTM |
This was referenced Jul 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the new Migration Analytics plugin that I am working on (https://github.com/mturley/cfme-migration_analytics), I need to consume the two Migration Readiness reports that were made available in #18749 to display the summary data required for https://bugzilla.redhat.com/show_bug.cgi?id=1708369.
I need to correlate the results of these two reports with other data from the ManageIQ API based on the
ext_management_system.idcolumn, which is not present in these reports. I could useext_management_system.name, but that assumes the user has not created two providers with the same name, which is technically possible.This PR adds the id field to these two reports so I can make a more robust relation with other
ext_management_systemAPI data.