Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing report headers #18950

Merged

Conversation

mzazrivec
Copy link
Contributor

This PR adds missing report headers for report columns added in #18944

Without this the ui-classic CI is failing with:

1) YAML reports regular reports 300_Migration Readiness - Virtual Machines/030_VMware VM Summary defines headers that match col_order
     Failure/Error: expect(headers).to eq(col_order)
     
       expected: 9
            got: 8
     
       (compared using ==)
     Shared Example Group: "all report type examples" called from ./spec/product/reports_spec.rb:65
     # ./spec/product/reports_spec.rb:26:in `block (3 levels) in <top (required)>'
  2) YAML reports regular reports 310_Migration Readiness - Providers/010_VMware Environment Summary defines headers that match col_order
     Failure/Error: expect(headers).to eq(col_order)
     
       expected: 8
            got: 7
     
       (compared using ==)
     Shared Example Group: "all report type examples" called from ./spec/product/reports_spec.rb:65
     # ./spec/product/reports_spec.rb:26:in `block (3 levels) in <top (required)>'

@miq-bot
Copy link
Member

miq-bot commented Jul 9, 2019

Checked commit mzazrivec@89c173a with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

@martinpovolny martinpovolny merged commit a3842e7 into ManageIQ:master Jul 9, 2019
@martinpovolny martinpovolny self-assigned this Jul 9, 2019
@mzazrivec mzazrivec deleted the add_missing_report_headers branch July 9, 2019 10:47
@mfeifer mfeifer added this to the Sprint 116 Ending Jul 22, 2019 milestone Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants