Enable workers as containers #19451
Merged
Enable workers as containers #19451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Fryguy I can contain the last commit to a hack in the containers code, but I figured this is probably the way it should have worked either way. |
Fryguy
reviewed
Oct 31, 2019
|
Have you verified that the existing non-container worker management still works as expected? |
Fryguy
approved these changes
Oct 31, 2019
This reverts commit 8467e94.
Artemis is not being used anymore and ENV["DATABASE_SERVICE_NAME"] is not set on the orchestrator pod.
This makes it easier for developers to specify alternate namespaces and registries for the worker images. The orchestrator will be provided the value as a part of the deploy process and will pass it along to all the worker deployments
Previously MiqWorker.workers would return the configured count even if the required roles for the worker type were not met.
Yup. |
|
Checked commits carbonin/manageiq@9d279ed~...469f730 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts the commit which disabled workers to be run as containers in OpenShift.
It also removes some information around artemis which is no longer planned to be used and fixes some additional bugs.
Notably it changes the
MiqWorker.workersmethod to return a count of 0 when we are missing a required role for the specific worker type. Previously this method would return the configured type regardless of the roles on the server. In OpenShift, this will allow us to scale down workers