Don't start every MetricsCollectorWorker #19683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this effectively revert #19494 ? It's hard to tell what the difference is besides the specs |
|
Also, can you fix the rubocops? |
Not exactly, I think what @carbonin was trying to do with #19494 was not override the method because #19451 added some logic to the base method which wasn't picked up by these workers because they overrode the whole method. I tried to keep that in spirit by calling out to super after the check for EMSs
Sure thing |
Fix the `#workers` method for any worker that includes the PerEmsTypeWorkerMixin (aka just the MetricsCollectorWorkers). This was setting an instance variable `@workers` but this wasn't actually being called so the ivar was never set up. This led to every metrics collector worker for every EMS type to be started if the role was enabled.
agrare
force-pushed
the
fix_starting_metrics_collector_workers
branch
from
d23840f
to
5cb0e6b
Compare
|
Checked commit agrare@5cb0e6b with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the
#workersmethod for any worker that includes the PerEmsTypeWorkerMixin (aka just the MetricsCollectorWorkers).This was setting an instance variable
@workersbut this wasn't actually being called so the ivar was never set up. This led to every metrics collector worker for every EMS type to be started if the role was enabled.#19494