Base monolithic container image on pods ui worker #19463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On a separate note, this makes this image very hard to build if you wanted to use it for development. I assume that's not the intention of this image? Otherwise we would probably have to separate out this image from the pods build tree completely and maintain a package list in a third location. |
Fryguy
reviewed
Nov 5, 2019
To do this I overwrote the entrypoint from the base image with what is mostly the previous appliance initialize script. The main changes I made were to add the server start at the end and to remove the old container scripts references by pasting the v2 key writing function into where it was previously called. Additionally I removed starting memcached from the block that only gets called if the database doesn't exist. We should start memcached regardless. This should allow the container to be started after a clean stop Fixes ManageIQ#17274
carbonin
force-pushed
the
base_monolithic_image_on_pods
branch
from
b51e2b8
to
e1df9e8
Compare
Fryguy
approved these changes
Nov 5, 2019
|
Checked commit carbonin@e1df9e8 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
Some comments on commit carbonin@e1df9e8 docker-assets/entrypoint
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To do this I overwrote the entrypoint from the base image with
what is mostly the previous appliance initialize script.
The main changes I made were to add the server start at the end
and to remove the old container scripts references by pasting
the v2 key writing function into where it was previously called.
Additionally I removed starting memcached from the block that only
gets called if the database doesn't exist. We should start memcached
regardless.
This should allow the container to be started after a clean stop
Fixes #17274