[IVANCHUK] Fix ivanchuk container image #19919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids the problems with the mount point caused by containers/buildah#2202 when using buildah
carbonin
changed the title
|
Checked commits carbonin/manageiq@f88f5e5~...f467002 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.20.0, and yamllint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies the same sort of changes to the ivanchuk branch as #19463 and #19920
In particular, it starts memcached and the database on container restarts and creates a volume for the application root directory.
Additionally it removes the ssh configuration as we haven't been running sshd in this container since we removed systemd and it moves the volume commands to the end of the file to avoid containers/buildah#2202
Fixes #19879